Restore AssignAttr.infer_lhs()#2235
Merged
jacobtylerwalls merged 3 commits intopylint-dev:mainfrom Jul 4, 2023
Merged
Conversation
Regression in 65df5e8.
This was referenced Jul 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
=======================================
Coverage 92.82% 92.83%
=======================================
Files 94 94
Lines 10930 10936 +6
=======================================
+ Hits 10146 10152 +6
Misses 784 784
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pierre-Sassoulas
approved these changes
Jul 4, 2023
DanielNoord
reviewed
Jul 4, 2023
Collaborator
DanielNoord
left a comment
DanielNoord
left a comment
There was a problem hiding this comment.
I like this approach much more than adding even more Mixins, but probably personal preference. Thanks for fixing it like this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Regression in 65df5e8.
Here is the kind of "helper function" I was referring to when I said I would remove the mixins added in #2171. (Three of them removed in #2231.) One method went missing during that latter PR.
I got tricked into thinking I didn't need that method, but it was just because both the pylint and astroid unit tests didn't cover it. Only the pylint stdlib primer suite caught it.
Closes pylint-dev/pylint#8823